adopted-ember-addons / adopted-ember-addons/validated-changeset

isDirty/isPristine don’t trigger computed property changes

Ouverte
#164 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
38
Forks
27
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

After updating `ember-changeset-validations` from 2.2.1 to 3.16.0, the computed properties that are dependent on `changeset.isDirty` are not updating when `changeset.isDirty` changes. This doesn't appear to be an issue for the other computed properties. Properties on the changeset that contain modified values trigger computed properties as expected.

Here is the project that recreates the issue. `isDirty/isPristine` computed properties do not get triggered. firstName property does get triggered as expected.

Github Link: [https://github.com/PVSAmulya/form-project](https://github.com/PVSAmulya/form-project)

When using ember-changeset 3.15.0 with ember-changeset-validations 2.2.1 `changeset.isDirty` computed property works as expected. I debugged this issue to validated-changeset.

There was a similar issue in ember-changeset for `isValid/isInvalid` that has been resolved.
[https://github.com/poteto/ember-changeset/issues/455](https://github.com/poteto/ember-changeset/issues/455)

Specific comment that is related to `isDirty` and `isPristine` on the PR that resolves the above issue.
[https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152](https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152)

Screen Shot 2022-03-03 at 1 07 28 PM

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.