adopted-ember-addons / adopted-ember-addons/validated-changeset

isDirty/isPristine don’t trigger computed property changes

Open
#164 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
38
Forks
27
PR merge metrics
No merged PRs in 30d

Description

After updating `ember-changeset-validations` from 2.2.1 to 3.16.0, the computed properties that are dependent on `changeset.isDirty` are not updating when `changeset.isDirty` changes. This doesn't appear to be an issue for the other computed properties. Properties on the changeset that contain modified values trigger computed properties as expected.

Here is the project that recreates the issue. `isDirty/isPristine` computed properties do not get triggered. firstName property does get triggered as expected.

Github Link: [https://github.com/PVSAmulya/form-project](https://github.com/PVSAmulya/form-project)

When using ember-changeset 3.15.0 with ember-changeset-validations 2.2.1 `changeset.isDirty` computed property works as expected. I debugged this issue to validated-changeset.

There was a similar issue in ember-changeset for `isValid/isInvalid` that has been resolved.
[https://github.com/poteto/ember-changeset/issues/455](https://github.com/poteto/ember-changeset/issues/455)

Specific comment that is related to `isDirty` and `isPristine` on the PR that resolves the above issue.
[https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152](https://github.com/poteto/ember-changeset/pull/509#issuecomment-644344152)

Screen Shot 2022-03-03 at 1 07 28 PM

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.