adobe / adobe/react-webcomponent

byContentVal does not update in cases where there are no children

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
104
Forks
20
PR merge metrics
No merged PRs in 30d

Description

### Expected Behaviour

A simple model like this should update if the contents of the node changes:
```
class ButtonModel extends DOMModel {
@byContentVal() label;
}
```

### Actual Behaviour

The initial contents of the DOM node is read, but the model does not respond to changes

### Reproduce Scenario (including but not limited to)

Any use of the `byContentVal` decorator that isn't in a child node

#### Steps to Reproduce

I will submit a PR that includes a test case

#### Platform and Version

Chrome 72, MacOS

#### Sample Code that illustrates the problem

I will submit a PR that includes a test case

#### Logs taken while reproducing problem

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.