abseil / abseil/abseil-cpp

[Bug]: zipf_distribution support is incomplete (q < 1 is unsupported right now)

未關閉
#1,818 2 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
C++
星號
18.1k
分支
3.2k
平均合併
20 小時 36 分鐘
30 天內合併 PR
1

描述

### Describe the issue

See comment at https://github.com/abseil/abseil-cpp/blob/master/absl/random/zipf_distribution.h#L38 regarding q > 1 precondition. We have use cases that require zipf q < 1.

This is mathematically well defined since the distribution is discrete over an alphabet [0, k]. q > 1 restriction only mathematically applies if one is sampling over the infinite range distribution [0, 1, ...].

### Steps to reproduce the problem

N/A, code at HEAD (0f102ad)

### What version of Abseil are you using?

0f102ad

### What operating system and version are you using?

Linux

### What compiler and version are you using?

N/A

### What build system are you using?

N/A

### Additional context

We require q < 1 for certain internal modeling at Meta.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。