abseil / abseil/abseil-cpp

[Bug]: zipf_distribution support is incomplete (q < 1 is unsupported right now)

Open
#1,818 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
18.1k
Forks
3.2k
Avg merge
20h 36m
Merged PRs (30d)
1

Description

### Describe the issue

See comment at https://github.com/abseil/abseil-cpp/blob/master/absl/random/zipf_distribution.h#L38 regarding q > 1 precondition. We have use cases that require zipf q < 1.

This is mathematically well defined since the distribution is discrete over an alphabet [0, k]. q > 1 restriction only mathematically applies if one is sampling over the infinite range distribution [0, 1, ...].

### Steps to reproduce the problem

N/A, code at HEAD (0f102ad)

### What version of Abseil are you using?

0f102ad

### What operating system and version are you using?

Linux

### What compiler and version are you using?

N/A

### What build system are you using?

N/A

### Additional context

We require q < 1 for certain internal modeling at Meta.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.