abseil / abseil/abseil-cpp

[Bug]: zipf_distribution support is incomplete (q < 1 is unsupported right now)

Abierto
#1,818 2 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
C++
Estrellas
18.1k
Forks
3.2k
Merge medio
20 h 36 min
PR fusionados (30 d)
1

Descripción

### Describe the issue

See comment at https://github.com/abseil/abseil-cpp/blob/master/absl/random/zipf_distribution.h#L38 regarding q > 1 precondition. We have use cases that require zipf q < 1.

This is mathematically well defined since the distribution is discrete over an alphabet [0, k]. q > 1 restriction only mathematically applies if one is sampling over the infinite range distribution [0, 1, ...].

### Steps to reproduce the problem

N/A, code at HEAD (0f102ad)

### What version of Abseil are you using?

0f102ad

### What operating system and version are you using?

Linux

### What compiler and version are you using?

N/A

### What build system are you using?

N/A

### Additional context

We require q < 1 for certain internal modeling at Meta.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.