aboutcode-org / aboutcode-org/scancode-toolkit

possible wrong rules triggering

Đang mở
#4,879 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug
Ngôn ngữ chính
Python
Star
2.6k
Fork
791
Merge trung bình
1 ngày 12 giờ
Pull request đã merge (30 ngày)
5

Mô tả

### Description

In the BusyBox project I can see the phrase

```
and put under GPLv2 license.
```
which can be found at https://github.com/mirror/busybox/blob/master/networking/tls_aes.c#L39

This triggers https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_818.RULE

but it doesn't report https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_493.RULE which would also be valid. This rule catches a little bit less, but also a little bit more. My question to @pombredanne and @AyanSinhaMahapatra is what the best course of action would be:

1. ignore and just go with the 818 rule
2. ignore and go with the 493 rule
3. create a new rule that combines the two rules

### How To Reproduce

> Tell us how to reproduce the issue.

### System configuration

> For bug reports, it really helps us to know:

* What OS are you running on? (Windows/MacOS/Linux)
* What version of scancode-toolkit was used to generate the scan file?
* What installation method was used to install/run scancode? (pip/source download/other)

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.