aboutcode-org / aboutcode-org/scancode-toolkit

possible wrong rules triggering

Abierto
#4,879 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
Python
Estrellas
2.6k
Forks
791
Merge medio
1 d 12 h
PR fusionados (30 d)
5

Descripción

### Description

In the BusyBox project I can see the phrase

```
and put under GPLv2 license.
```
which can be found at https://github.com/mirror/busybox/blob/master/networking/tls_aes.c#L39

This triggers https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_818.RULE

but it doesn't report https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_493.RULE which would also be valid. This rule catches a little bit less, but also a little bit more. My question to @pombredanne and @AyanSinhaMahapatra is what the best course of action would be:

1. ignore and just go with the 818 rule
2. ignore and go with the 493 rule
3. create a new rule that combines the two rules

### How To Reproduce

> Tell us how to reproduce the issue.

### System configuration

> For bug reports, it really helps us to know:

* What OS are you running on? (Windows/MacOS/Linux)
* What version of scancode-toolkit was used to generate the scan file?
* What installation method was used to install/run scancode? (pip/source download/other)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.