aboutcode-org / aboutcode-org/scancode-toolkit

possible wrong rules triggering

Open
#4,879 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
2.6k
Forks
791
Avg merge
1d 12h
Merged PRs (30d)
5

Description

### Description

In the BusyBox project I can see the phrase

```
and put under GPLv2 license.
```
which can be found at https://github.com/mirror/busybox/blob/master/networking/tls_aes.c#L39

This triggers https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_818.RULE

but it doesn't report https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_493.RULE which would also be valid. This rule catches a little bit less, but also a little bit more. My question to @pombredanne and @AyanSinhaMahapatra is what the best course of action would be:

1. ignore and just go with the 818 rule
2. ignore and go with the 493 rule
3. create a new rule that combines the two rules

### How To Reproduce

> Tell us how to reproduce the issue.

### System configuration

> For bug reports, it really helps us to know:

* What OS are you running on? (Windows/MacOS/Linux)
* What version of scancode-toolkit was used to generate the scan file?
* What installation method was used to install/run scancode? (pip/source download/other)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.