aboutcode-org / aboutcode-org/extractcode

Side effects on locale and timezone when importing `extractcode.libarchive2` as library

未關閉
#65 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
39
分支
23
PR 合併指標
30 天內沒有已合併 PR

描述

Importing `extractcode.libarchive2` has unexpected side effects on the caller, especially when used as a library inside a larger project.

In my specific case, the base application is running with the `Europe/Berlin` timezone, as this is my local time. After having executed some extraction code involving the aforementioned module, my timezone is set to UTC. This only became obvious because my logging showed that processing the archive finished nearly two hours before starting the process.

The reason is https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/libarchive2.py#L135-L143 In my opinion, libraries should not change such stuff globally without any warning.

Edit: It seems like these aspects are not covered by unit tests as well, which makes evaluating alternatives or removing these lines harder.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。