aboutcode-org / aboutcode-org/extractcode

Side effects on locale and timezone when importing `extractcode.libarchive2` as library

Aberta
#65 1 comentário 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Python
Estrelas
39
Forks
23
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Importing `extractcode.libarchive2` has unexpected side effects on the caller, especially when used as a library inside a larger project.

In my specific case, the base application is running with the `Europe/Berlin` timezone, as this is my local time. After having executed some extraction code involving the aforementioned module, my timezone is set to UTC. This only became obvious because my logging showed that processing the archive finished nearly two hours before starting the process.

The reason is https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/libarchive2.py#L135-L143 In my opinion, libraries should not change such stuff globally without any warning.

Edit: It seems like these aspects are not covered by unit tests as well, which makes evaluating alternatives or removing these lines harder.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.