aboutcode-org / aboutcode-org/extractcode

Side effects on locale and timezone when importing `extractcode.libarchive2` as library

未关闭
#65 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
39
派生
23
PR 合并指标
30 天内没有已合并 PR

描述

Importing `extractcode.libarchive2` has unexpected side effects on the caller, especially when used as a library inside a larger project.

In my specific case, the base application is running with the `Europe/Berlin` timezone, as this is my local time. After having executed some extraction code involving the aforementioned module, my timezone is set to UTC. This only became obvious because my logging showed that processing the archive finished nearly two hours before starting the process.

The reason is https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/libarchive2.py#L135-L143 In my opinion, libraries should not change such stuff globally without any warning.

Edit: It seems like these aspects are not covered by unit tests as well, which makes evaluating alternatives or removing these lines harder.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。