aboutcode-org / aboutcode-org/extractcode

Side effects on locale and timezone when importing `extractcode.libarchive2` as library

Open
#65 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
39
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Importing `extractcode.libarchive2` has unexpected side effects on the caller, especially when used as a library inside a larger project.

In my specific case, the base application is running with the `Europe/Berlin` timezone, as this is my local time. After having executed some extraction code involving the aforementioned module, my timezone is set to UTC. This only became obvious because my logging showed that processing the archive finished nearly two hours before starting the process.

The reason is https://github.com/aboutcode-org/extractcode/blob/db9dd083239302220b996bcf9c1914cd5c3ff016/src/extractcode/libarchive2.py#L135-L143 In my opinion, libraries should not change such stuff globally without any warning.

Edit: It seems like these aspects are not covered by unit tests as well, which makes evaluating alternatives or removing these lines harder.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.