abcxyz / abcxyz/github-metrics-aggregator

Use a limited time window when looking for duplicates

Aperta
#138 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement good first issue
Lingua principale
Go
Stelle
16
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Currently before we add to the PubSub topic, we do a query to ensure the row doesn't already exist in the table:
https://github.com/abcxyz/github-metrics-aggregator/blob/bae8a213956a38ffb2ca721820c92af0235bde2c/pkg/webhook/bigquery.go#L117

It would be better if we used a WHERE to limit the amount of data that gets scanned to something more like a week.

This should probably be done by adding an additional argument to the chain of functions this is the base of.

This is low priority since the payload column isn't selected.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.