abcxyz / abcxyz/github-metrics-aggregator

Use a limited time window when looking for duplicates

Ouverte
#138 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
enhancement good first issue
Langage dominant
Go
Étoiles
16
Forks
3
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently before we add to the PubSub topic, we do a query to ensure the row doesn't already exist in the table:
https://github.com/abcxyz/github-metrics-aggregator/blob/bae8a213956a38ffb2ca721820c92af0235bde2c/pkg/webhook/bigquery.go#L117

It would be better if we used a WHERE to limit the amount of data that gets scanned to something more like a week.

This should probably be done by adding an additional argument to the chain of functions this is the base of.

This is low priority since the payload column isn't selected.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.