abcxyz / abcxyz/github-metrics-aggregator

Use a limited time window when looking for duplicates

Offen
#138 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement good first issue
Vorherrschende Sprache
Go
Sterne
16
Forks
3
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Currently before we add to the PubSub topic, we do a query to ensure the row doesn't already exist in the table:
https://github.com/abcxyz/github-metrics-aggregator/blob/bae8a213956a38ffb2ca721820c92af0235bde2c/pkg/webhook/bigquery.go#L117

It would be better if we used a WHERE to limit the amount of data that gets scanned to something more like a week.

This should probably be done by adding an additional argument to the chain of functions this is the base of.

This is low priority since the payload column isn't selected.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.