abcxyz / abcxyz/github-metrics-aggregator

Use a limited time window when looking for duplicates

未關閉
#138 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement good first issue
主要語言
Go
星號
16
分支
3
PR 合併指標
30 天內沒有已合併 PR

描述

Currently before we add to the PubSub topic, we do a query to ensure the row doesn't already exist in the table:
https://github.com/abcxyz/github-metrics-aggregator/blob/bae8a213956a38ffb2ca721820c92af0235bde2c/pkg/webhook/bigquery.go#L117

It would be better if we used a WHERE to limit the amount of data that gets scanned to something more like a week.

This should probably be done by adding an additional argument to the chain of functions this is the base of.

This is low priority since the payload column isn't selected.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。