aagarwal1012 / aagarwal1012/Image-Steganography-Library-Android

Secret key of length >16 doesn't work

未關閉
#22 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Java
星號
160
分支
66
PR 合併指標
30 天內沒有已合併 PR

描述

**Describe the bug**
If the user passes secret key of length >16 to ImageSteganography constructor the convertKeyTo128bit method won't convert it properly.
Instead of:
result = result.substring(0, 16);
it has:
result = result.substring(0, 15);

And the encryption step fails then.

**Possible solution without the pull request**
It is easy to fix in the library, but if it won't be fixed here is an easy workaround:
1. Create class ImageSteganographyV2 which extends ImageSteganography
2. Copy the whole code(since ImageSteganography doesn't open access to fields)
3. Fix the bug by changing 15 to 16 in "result = result.substring(0, 15);"
4. Create ImageSteganography instances using new class. For example:

```ImageSteganography imageSteganography = new ImageSteganographyV2(message, secretKey, originalImage);```

Everything else can stay the same

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。