aagarwal1012 / aagarwal1012/Image-Steganography-Library-Android

Secret key of length >16 doesn't work

Open
#22 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
160
Forks
66
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
If the user passes secret key of length >16 to ImageSteganography constructor the convertKeyTo128bit method won't convert it properly.
Instead of:
result = result.substring(0, 16);
it has:
result = result.substring(0, 15);

And the encryption step fails then.

**Possible solution without the pull request**
It is easy to fix in the library, but if it won't be fixed here is an easy workaround:
1. Create class ImageSteganographyV2 which extends ImageSteganography
2. Copy the whole code(since ImageSteganography doesn't open access to fields)
3. Fix the bug by changing 15 to 16 in "result = result.substring(0, 15);"
4. Create ImageSteganography instances using new class. For example:

```ImageSteganography imageSteganography = new ImageSteganographyV2(message, secretKey, originalImage);```

Everything else can stay the same

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.