aagarwal1012 / aagarwal1012/Image-Steganography-Library-Android

Secret key of length >16 doesn't work

Ouverte
#22 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Java
Étoiles
160
Forks
66
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

**Describe the bug**
If the user passes secret key of length >16 to ImageSteganography constructor the convertKeyTo128bit method won't convert it properly.
Instead of:
result = result.substring(0, 16);
it has:
result = result.substring(0, 15);

And the encryption step fails then.

**Possible solution without the pull request**
It is easy to fix in the library, but if it won't be fixed here is an easy workaround:
1. Create class ImageSteganographyV2 which extends ImageSteganography
2. Copy the whole code(since ImageSteganography doesn't open access to fields)
3. Fix the bug by changing 15 to 16 in "result = result.substring(0, 15);"
4. Create ImageSteganography instances using new class. For example:

```ImageSteganography imageSteganography = new ImageSteganographyV2(message, secretKey, originalImage);```

Everything else can stay the same

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.