a8m / a8m/angular-filter

Add ===null to all filter params

未關閉
#114 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
2.9k
分支
319
PR 合併指標
30 天內沒有已合併 PR

描述

Currently the (in my instance) fuzzyBy filter has this code in it

```
if(!isArray(collection) || isUndefined(property)
|| isUndefined(search)) {
return collection;
}
```

Search is the key word. Now say i have this value modeled to an input, when the input is blank it is set to null, but angular.isUndefined() does a typeof check on the value, not a ==undefined, or ==null.

Because of this whenever the input is blank nothing is returned by the filter. This is not the desired result is it?

This is simply fixed by changing the above to

```
if(!isArray(collection) || isUndefined(property)
|| search == null) {
return collection;
}
```

Because ==null will evaluate to true if search is null or undefined this should fit the bill here.

Are there any downsides to doing this everywhere?

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。