Add ===null to all filter params
- Lingua principale
- JavaScript
- Stelle
- 2.9k
- Fork
- 319
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Currently the (in my instance) fuzzyBy filter has this code in it
```
if(!isArray(collection) || isUndefined(property)
|| isUndefined(search)) {
return collection;
}
```
Search is the key word. Now say i have this value modeled to an input, when the input is blank it is set to null, but angular.isUndefined() does a typeof check on the value, not a ==undefined, or ==null.
Because of this whenever the input is blank nothing is returned by the filter. This is not the desired result is it?
This is simply fixed by changing the above to
```
if(!isArray(collection) || isUndefined(property)
|| search == null) {
return collection;
}
```
Because ==null will evaluate to true if search is null or undefined this should fit the bill here.
Are there any downsides to doing this everywhere?
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.