a8m / a8m/angular-filter

Add ===null to all filter params

Ouverte
#114 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
2.9k
Forks
319
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently the (in my instance) fuzzyBy filter has this code in it

```
if(!isArray(collection) || isUndefined(property)
|| isUndefined(search)) {
return collection;
}
```

Search is the key word. Now say i have this value modeled to an input, when the input is blank it is set to null, but angular.isUndefined() does a typeof check on the value, not a ==undefined, or ==null.

Because of this whenever the input is blank nothing is returned by the filter. This is not the desired result is it?

This is simply fixed by changing the above to

```
if(!isArray(collection) || isUndefined(property)
|| search == null) {
return collection;
}
```

Because ==null will evaluate to true if search is null or undefined this should fit the bill here.

Are there any downsides to doing this everywhere?

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.