More proper way for displaying function pointers in structures in linear view

Open
#4,115 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
frontend, reverse-engineering

Research direction

Start by reading the related issue #3540 and examining how structure members and function-pointer prototypes are rendered in the linear view. Done means vft members with long function-pointer signatures are easier to distinguish, including when two Binary Ninja views are shown side by side.

Written by the indexing model from the issue text.

Description

Component: UI Effort: Medium Impact: Medium UI: Linear

I've opened a general issue for this before as #3540 and I mentioned this problem in my second message in it. But I frequently get into trouble with this spesific example, so I want to open an seperate issue for it in order to make people find it more easy.

struct cc_handler_vft cc_handler_vftl = 
{
    void (* handle_cc_command)(struct cc_handler* this, int32_t a2, void (*** lpAddress)(void*, int32_t)) = handle_cc_command
    int32_t (* cc_handler_destroy)(struct cc_handler* this) = cc_handler_destroy
}

As you can see, it makes it very hard to see members of vft. Especially if there are a lot of them with longer prototypes and I open two BN side-by-side.

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.