TanStack / TanStack/tanstack.com

Keep dependency updates compatible with the OpenAI continuation patch

オープン
#1,212 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

source-audit
主要言語
TypeScript
スター
1.1k
フォーク
401
平均マージ
18時間 14分
マージ済み PR(30日)
56

説明

Evidence

The scheduled Update TanStack Dependencies run failed before lint or build on August 30. The exact pnpm up "@tanstack/*" --latest step exits with ERR_PNPM_UNUSED_PATCH because it moves @tanstack/openai-base away from the patched 0.10.5 version.

I reproduced the same failure from current main at 6584b153. In an isolated worktree, allowing unused patches let the update finish and changed @tanstack/ai-openai from 0.22.0 to 0.22.3, with @tanstack/openai-base moving from patched 0.10.5 to unpatched 0.10.8. The focused tests/openai-responses-tool-continuation.test.ts test then failed because the second request had no previous_response_id. The current patch is still required for sequential server-tool turns with provider-side reasoning.

Exact title, body, workflow, patch-package, and keyword searches found no open issue or PR that owns this failure.

Expected impact

The weekly dependency updater is currently guaranteed to fail whenever it tries the latest TanStack AI family. It never reaches the repository lint or build steps, so unrelated TanStack dependency updates also stop. Simply setting allowUnusedPatches or deleting the patch would make the workflow advance while regressing the Builder tool-continuation contract.

Proposed direction

Keep the focused continuation test as the release gate, then choose one owner for the patched AI family:

  1. Preferred long-term direction: ship the continuation behavior upstream, update the AI packages to the first release containing it, prove the focused test passes without the local patch, and delete the patch.
  2. Until that release exists: upgrade the pinned pnpm from 11.1.0 to a version that supports update.ignoreDeps and exclude the cohesive TanStack AI package set from the scheduled bulk updater. Upgrade that set separately, carrying the patch forward only after its focused test and the full suite pass.

Alternatives and tradeoffs

  • Manually port the 321-line patch to every new openai-base release. This keeps AI packages moving, but each port needs careful review against upstream adapter changes and should not be committed straight to main by a broad scheduled update.
  • Let pnpm up ignore unused patches. This unblocks the job but silently removes required runtime behavior, and the isolated focused test already proves the regression.
  • Exclude only @tanstack/ai-openai. This may still let related direct or transitive AI packages move out of a tested version set, so excluding and reviewing the cohesive AI family is safer.

Decision needed

@tannerlinsley, should we first upgrade pnpm and hold the TanStack AI family out of the weekly bulk updater, or prioritize landing the continuation behavior upstream and keep the weekly job blocked until a release contains it?

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

まず、予定されている pnpm up "@tanstack/*" --latest のステップを再現し、現在の依存関係パッチに対して tests/openai-responses-tool-continuation.test.ts を実行します。issue に記載されている updater workflow、pnpm 設定、パッチ処理を調査します。TanStack AI ファミリーを継続動作にリグレッションを生じさせずに更新でき、workflow が lint と build まで到達すれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
github-actions, typescript
領域
ci-cd, devops, testing-qa
issue の種類
バグ
難易度
5/5
見積もり時間
1週間以上
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。