TanStack / TanStack/tanstack.com

Keep dependency updates compatible with the OpenAI continuation patch

Abierto
#1,212 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

source-audit
Lenguaje dominante
TypeScript
Estrellas
1.1k
Forks
401
Merge medio
18 h 14 min
PR fusionados (30 d)
56

Descripción

Evidence

The scheduled Update TanStack Dependencies run failed before lint or build on August 30. The exact pnpm up "@tanstack/*" --latest step exits with ERR_PNPM_UNUSED_PATCH because it moves @tanstack/openai-base away from the patched 0.10.5 version.

I reproduced the same failure from current main at 6584b153. In an isolated worktree, allowing unused patches let the update finish and changed @tanstack/ai-openai from 0.22.0 to 0.22.3, with @tanstack/openai-base moving from patched 0.10.5 to unpatched 0.10.8. The focused tests/openai-responses-tool-continuation.test.ts test then failed because the second request had no previous_response_id. The current patch is still required for sequential server-tool turns with provider-side reasoning.

Exact title, body, workflow, patch-package, and keyword searches found no open issue or PR that owns this failure.

Expected impact

The weekly dependency updater is currently guaranteed to fail whenever it tries the latest TanStack AI family. It never reaches the repository lint or build steps, so unrelated TanStack dependency updates also stop. Simply setting allowUnusedPatches or deleting the patch would make the workflow advance while regressing the Builder tool-continuation contract.

Proposed direction

Keep the focused continuation test as the release gate, then choose one owner for the patched AI family:

  1. Preferred long-term direction: ship the continuation behavior upstream, update the AI packages to the first release containing it, prove the focused test passes without the local patch, and delete the patch.
  2. Until that release exists: upgrade the pinned pnpm from 11.1.0 to a version that supports update.ignoreDeps and exclude the cohesive TanStack AI package set from the scheduled bulk updater. Upgrade that set separately, carrying the patch forward only after its focused test and the full suite pass.

Alternatives and tradeoffs

  • Manually port the 321-line patch to every new openai-base release. This keeps AI packages moving, but each port needs careful review against upstream adapter changes and should not be committed straight to main by a broad scheduled update.
  • Let pnpm up ignore unused patches. This unblocks the job but silently removes required runtime behavior, and the isolated focused test already proves the regression.
  • Exclude only @tanstack/ai-openai. This may still let related direct or transitive AI packages move out of a tested version set, so excluding and reviewing the cohesive AI family is safer.

Decision needed

@tannerlinsley, should we first upgrade pnpm and hold the TanStack AI family out of the weekly bulk updater, or prioritize landing the continuation behavior upstream and keep the weekly job blocked until a release contains it?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza reproduciendo el paso programado pnpm up "@tanstack/*" --latest y ejecuta tests/openai-responses-tool-continuation.test.ts contra el parche de dependencias actual. Inspecciona el workflow del updater, la configuración de pnpm y el manejo del parche descritos en el issue. Se considera terminado cuando la familia TanStack AI pueda actualizarse sin regresiones en el comportamiento de continuación y el workflow llegue a lint y build.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions, typescript
Área
ci-cd, devops, testing-qa
Tipo de issue
Error
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.