PowerShell / PowerShell/PSScriptAnalyzer

Update/standardize the internal custom `VariableAnalysis` classes

Open
#1,283 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area - Engine Consider - 2.0 Issue - Enhancement
Dominant language
C#
Stars
2.2k
Forks
414
Avg merge
13h 1m
Merged PRs (30d)
2

Description

This addresses technical debt.

... the VariableAnalysis classes that were forked from PowerShell's own classes 4 years ago. Those classes were not updated since and have small bugs that leads to certain types of analysis not being possible. Unfortunately, the original maintainers have taken only a subset of it and added a lot of custom code to it. I once tried to just delete it and replace it with the code from PowerShell and some of the challenges were that SMA are very entangled with each other in terms of dependencies and it compiles against .Net Core, but PSSA compiles against .Net Standard.

(https://github.com/PowerShell/PSScriptAnalyzer/pull/1277#issuecomment-508929230)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked discussion in PowerShell/PSScriptAnalyzer#1277 and identifying the internal VariableAnalysis classes and their dependencies. Compare the forked classes with PowerShell's versions while accounting for the .NET Core and .NET Standard compilation targets. Done means the technical debt, known analysis bugs, and dependency or framework constraints are addressed without breaking the analyzer.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, powershell
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.