Issues with Insiders changes and themes
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- powershell
- Domain
- tooling
Research direction
No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.
Written by the indexing model from the issue text.
Description
Environment
- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
- Your primary theme: Microsoft's Monokai
Issue Description
With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.
If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.
I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.
Screenshots
Insiders

Stable

Insiders

Stable

Insiders

Stable

Expected Behavior
Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.
If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.
- Dominant language
- PowerShell
- Stars
- 151
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PowerShell/EditorSyntax
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
PowerShell/EditorSyntax#224 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
PowerShell/EditorSyntax#222 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
PowerShell/EditorSyntax#221 · 2 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
PowerShell/EditorSyntax#220 · 2 comments · 1 reaction ·
-
Issue-Bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
PowerShell/EditorSyntax#219 · 2 comments ·
All issues in PowerShell/EditorSyntax
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
nearform/ag-grid-url-sync#160 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
idean3885/claude-ops-agent#521 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
0xMiden/bridge-portal#132 ·