Issues with Insiders changes and themes
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Bug
- Chiarezza
- Da chiarire
- Stato di attività
- Ferma
- Stack tecnologico
- powershell
- Ambito
- tooling
Direzione di ricerca
No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Environment
- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
- Your primary theme: Microsoft's Monokai
Issue Description
With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.
If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.
I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.
Screenshots
Insiders

Stable

Insiders

Stable

Insiders

Stable

Expected Behavior
Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.
If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.
- Lingua principale
- PowerShell
- Stelle
- 151
- Fork
- 55
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di PowerShell/EditorSyntax
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/EditorSyntax#224 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
PowerShell/EditorSyntax#222 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 55/100
PowerShell/EditorSyntax#221 · 2 commenti ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 45/100
PowerShell/EditorSyntax#220 · 2 commenti · 1 reazione ·
-
Issue-Bug
Difficoltà 3/5 1-2 giorni Idoneità per principianti 48/100
PowerShell/EditorSyntax#219 · 2 commenti ·
Tutte le issue di PowerShell/EditorSyntax
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
phpstan/phpstan-doctrine#794 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
nearform/ag-grid-url-sync#160 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
idean3885/claude-ops-agent#521 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
0xMiden/bridge-portal#132 ·