Issues with Insiders changes and themes
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Error
- Claridad
- Necesita aclaración
- Estado de actividad
- Estancado
- Stack tecnológico
- powershell
- Área
- tooling
Línea de trabajo
No repository files or tests are named. Start by reproducing the difference between VSCode 1.26.0-insider and the stable branch with Microsoft's Monokai and the screenshots' syntax examples, then trace the syntax-scoping changes affecting themes. Done means the relevant syntax renders consistently in Insiders and stable without requiring theme-specific fixes.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Environment
- Editor and Version (VS Code, Atom, Sublime): VSCode 1.26.0-insider
- Your primary theme: Microsoft's Monokai
Issue Description
With the changes to the syntax it breaks most every theme. I have had to revert to the stable branch because I can't find a usable theme that doesn't mess with my eyes. A change like this was attempted in the past, and had to be reverted. I think @daviwil and @gravejester can give more details on some of those.
If you want to correct the syntax and make the scoping right, you need to have the major themes supporting it and looking how users expect before you roll out the changes to the syntax. This has been a major disruption in my work. I spent half my workday trying to get my editor to look decent enough to get back to work, and eventually had to revert to stable, but that won't always be an option.
I don't think telling users to submit a pull request to fix a theme is the appropriate way to handle this. I can't think of many powershell users who may know how to even go about adding support to the theme they use. This syntax is a tool that people use to make a living.
Screenshots
Insiders

Stable

Insiders

Stable

Insiders

Stable

Expected Behavior
Users expect the themes to look how they currently look. There is very little that looks the same between insiders and stable. The only thing that stands out that is the same is basic strings.
If you can't implement fixes without breaking every theme, then I don't think you should push this until you can come up with a better way to roll these out without impacting every single powershell user. If these changes have to go through, then at the very least make sure the most popular themes will look the same as they do now.
- Lenguaje dominante
- PowerShell
- Estrellas
- 151
- Forks
- 55
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de PowerShell/EditorSyntax
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#224 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#222 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 55/100
PowerShell/EditorSyntax#221 · 2 comentarios ·
-
Dificultad 3/5 1-2 días Aptitud para principiantes 45/100
PowerShell/EditorSyntax#220 · 2 comentarios · 1 reacción ·
-
Issue-Bug
Dificultad 3/5 1-2 días Aptitud para principiantes 48/100
PowerShell/EditorSyntax#219 · 2 comentarios ·
Todos los issues de PowerShell/EditorSyntax
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
0xMiden/bridge-portal#132 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
newrelic-experimental/preflight#793 · 1 comentario ·
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
babalae/bettergi-scripts-list#3674 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
caddyserver/caddy#8046 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
zilliztech/memsearch#759 ·