PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Imported a build and broke all of my saved builds

Open
#9,844 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Open saved builds

How does Path of Building behave?

I open any build or try to create a new one and it gives me the below error, I have about 30 saved builds but the most recent is a build I've been working on for 2 leagues and it worked yesterday.

Error:

In 'OnFrame': Classes/PassiveSpec.lua:1694: Entrance for subGraph not linked to parent socket???
stack traceback:
[C]: in function 'assert'
Classes/PassiveSpec.lua:1694: in function 'BuildClusterJewelGraphs'
Classes/ItemSlotControl.lua:65: in function 'SetSelItemId'
Classes/ItemSlotControl.lua:94: in function 'Populate'
Classes/ItemsTab.lua:1418: in function 'PopulateSlots'
Classes/ItemsTab.lua:1379: in function <Classes/ItemsTab.lua:1355>
Classes/ItemsTab.lua:998: in function '_constructor'
Modules/Common.lua:148: in function 'new'
Modules/Build.lua:601: in function 'CallMode'
Modules/Main.lua:355: in function <Modules/Main.lua:341>
[C]: in function 'PCall'
Launch.lua:111: in function Launch.lua:108
v2.65.0 master
Press Enter/Escape to dismiss, or F5 to restart the application.
Press CTRL + C to copy error text.

How to reproduce the issue

I believe this error started appearing when I imported the below pobb.in
https://pobb.in/6mYVGAjp
This can be found here
https://www.pathofexile.com/forum/view-thread/3264207/page/132#p26578806
I've since deleted the saved build but it doesn't seem to be helping. I was able to look at the build but on booting PoB today it's not happy.

PoB for PoE1 build code
https://pobb.in/6mYVGAjp
Screenshots

N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by importing https://pobb.in/6mYVGAjp, then start with the assertion at Classes/PassiveSpec.lua:1694 and follow the stack through Classes/ItemSlotControl.lua, Classes/ItemsTab.lua, Modules/Build.lua, and Modules/Main.lua. Confirm the fix by opening existing saved builds and creating a new build without the error.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.