PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

The Apostate vs. %Crit multi per 10 es shield mastery - POB incorrectly adds crit multi

Open
#9,672 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

Shield mastery does not add any crit multi when using a shield with ES and wearing The Apostate

What is the value from the calculation in Path of Building?

When using The Apostate armour (all ES from armour items converted to life), Shield mastery's "crit multi per 10 es on equipped shield" adds crit multi.

How to reproduce the issue

WTR:

  • equip The Apostate
  • equip a shield with ES
  • allocate shield mastery that gives crit multi per 10 ES on shield

in game: no effect
in POB: adds crit multi despite es->life conversion

PoB for PoE1 build code
https://pobb.in/MX-nefhXaz2q
Screenshots
Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by loading the linked PoB build code in Path of Building and reproduce the difference between The Apostate with an energy-shielded equipped shield in-game and in PoB. Trace the shield mastery critical-multiplier calculation and verify that it no longer contributes when The Apostate converts the relevant energy shield to life; add or update a regression test if the calculation test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.