Hit Rate with Max Unleash Seals is incorrect when Cast Rate is high enough

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-game when waiting for Max Unleash Seals, I believe Hit Rate should be calculated as the lower of the following two:

1. 1 / Time to Gain Max Seals
2. Cast Rate / (1 + Max Seals * 0.1)

So the value would be (with placeholder stats):

• Time to Gain Max Seals = 1.5s
• Cast Rate = 3/s
• Max Seals = 8
• 1 / Time to Gain Max Seals = 1 / 1.5 = 0.67 Hit Rate
• Cast Rate / (1 + Max Seals * 0.1) = 3 / (1 + 8 * 0.1) = 1.67 Hit Rate
• 0.67 is the lower of the two, so that should be the Hit Rate used

What is the value from the calculation in Path of Building?

In PoB, when config is set to Wait for Max Unleash Seals, PoB calculates Hit Rate as whichever is lower:

1. 1 / Time to Gain Max Seals
2. 1 / (Cast Rate * 1.1)

So it calculates the incorrect value (with placeholder stats):

• Time to Gain Max Seals = 1.5s
• Cast Rate = 3/s
• Max Seals = 8
• 1 / Time to Gain Max Seals = 1 / 1.5 = 0.67 Hit Rate
• 1 / (Cast Rate * 1.1) = 1 / (3 * 1.1) = 0.30 Hit Rate
• 0.30 is the lower of the two, so it chooses that (and so higher cast speed = lower hit rate and DPS currently)

How to reproduce the issue

1. Select Arc as the main skill
2. Add Unleash Support to Arc
3. Tick on Do you wait for Max Unleash Seals?
4. Increase cast speed until (Cast Rate * 1.1) > Time to Gain Max Seals (On new file, 100% increased cast speed is enough)
5. See incorrect Hit Rate based on inverse of 110% of Case Rate

PoB for PoE1 build code

https://pobb.in/-OiTWyTB33fj

Screenshots

When Time to Gain Max Seals is greater than 110% of Cast Rate:

When 110% of Cast Rate is greater than Time to Gain Max Seals:

Tái hiện vấn đề bằng mã build PoE1 được liên kết, sử dụng Arc, Unleash Support và “Do you wait for Max Unleash Seals?”. Truy vết phép tính tỷ lệ đánh trúng cho thiết lập đó, sau đó xác minh rằng nó sử dụng giá trị thấp hơn giữa tỷ lệ nhận seal và biểu thức tốc độ niệm phép có liên quan đến Max Seals; xác nhận kết quả ở tốc độ niệm phép cao.