PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Hit Rate with Max Unleash Seals is incorrect when Cast Rate is high enough

未关闭
#9,601 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug: calculation
主要语言
Lua
星标
5.4k
派生
2.4k
平均合并
1 天 12 小时
30 天内合并 PR
26

描述

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

In-game when waiting for Max Unleash Seals, I believe Hit Rate should be calculated as the lower of the following two:

  1. 1 / Time to Gain Max Seals
  2. Cast Rate / (1 + Max Seals * 0.1)

So the value would be (with placeholder stats):

  • Time to Gain Max Seals = 1.5s
  • Cast Rate = 3/s
  • Max Seals = 8
  • 1 / Time to Gain Max Seals = 1 / 1.5 = 0.67 Hit Rate
  • Cast Rate / (1 + Max Seals * 0.1) = 3 / (1 + 8 * 0.1) = 1.67 Hit Rate
  • 0.67 is the lower of the two, so that should be the Hit Rate used
What is the value from the calculation in Path of Building?

In PoB, when config is set to Wait for Max Unleash Seals, PoB calculates Hit Rate as whichever is lower:

  1. 1 / Time to Gain Max Seals
  2. 1 / (Cast Rate * 1.1)

So it calculates the incorrect value (with placeholder stats):

  • Time to Gain Max Seals = 1.5s
  • Cast Rate = 3/s
  • Max Seals = 8
  • 1 / Time to Gain Max Seals = 1 / 1.5 = 0.67 Hit Rate
  • 1 / (Cast Rate * 1.1) = 1 / (3 * 1.1) = 0.30 Hit Rate
  • 0.30 is the lower of the two, so it chooses that (and so higher cast speed = lower hit rate and DPS currently)
How to reproduce the issue
  1. Select Arc as the main skill
  2. Add Unleash Support to Arc
  3. Tick on Do you wait for Max Unleash Seals?
  4. Increase cast speed until (Cast Rate * 1.1) > Time to Gain Max Seals (On new file, 100% increased cast speed is enough)
  5. See incorrect Hit Rate based on inverse of 110% of Case Rate
PoB for PoE1 build code
https://pobb.in/-OiTWyTB33fj
Screenshots

When Time to Gain Max Seals is greater than 110% of Cast Rate:
Image

When 110% of Cast Rate is greater than Time to Gain Max Seals:
Image

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

使用链接的 PoE1 build 代码、Arc、Unleash Support 和“Do you wait for Max Unleash Seals?”重现该问题。追踪该设置的命中率计算,然后验证它使用的是 seal 获取速率与涉及 Max Seals 的施法速率表达式两者中的较低值;在高施法速度下确认结果。

由索引模型根据 Issue 内容生成。

评估

技术栈
lua
领域
game-dev
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。