PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Rounding problem with MH More
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 5.4k
- Forks
- 2.4k
- Merge moyen
- 1 j 12 h
- PR mergées (30 j)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the value from the calculation in-game?
N/A
What is the value from the calculation in Path of Building?
There seems to be an error where the Hit DPS of a Ballista x the number of Ballistas is not quite the same as the value in Full DPS. It looks like it might be related to some rounding in MH More - one number is from the rounded version and one is from the unrounded.
How to reproduce the issue
The PoB is POEGuy's Shrapnel Ballista with Mageblood - all I've done is set to the distance to 35 (to remove one factor) and turn on Frenzy.
For Shrapnel Ballistas, the MH Total More calculation is 1.95 from Ritual of Awakening (5% x19 totems) and 1.12 from Frenzy (4% per charge) - this comes to 2.184, so that's displayed as 118%, rounded to a percent.
The rest of the calculations on the Calcs page seem to be using 118% (x2.18) as the base - the More/Less on the Chaos Hit Damage is 3.052, which is 1.4 (from Awakened Void Manipulation) x 2.18 - 2.184 would produce 3.0576.
All the rest of the calculations seem to proceed as normal from there on (using the slightly smaller figure) up to the Skill DPS of 165,413.4, which matches the Hit DPS in the Main Skill section on the left. When you scale that up to 19 Ballistas, you get 3,142,854.6, not the 3,148,625.2 that the Full DPS reports. But, if you go back and use 2.184 as the MH Total More, you get the Full DPS figure on the nose - I'm guessing there's two paths to those two figures, and one of them is using the rounded version, and one not?
PoB for PoE1 build code
https://pobb.in/Zph_U_7yZPg1
Screenshots
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Reproduisez le PoB lié sur la page Calcs avec distance défini sur 35 et Frenzy activé. Comparez la valeur de MH Total More utilisée par Chaos Hit Damage et Skill DPS avec celle utilisée par Full DPS ; l’issue est terminée lorsque les chemins de calcul arrondi et non arrondi produisent des totaux cohérents pour les 19 Ballistas.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- desktop
- Type d'issue
- Bug
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100