PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Rounding problem with MH More

Offen
#9,423 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: calculation
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

N/A

What is the value from the calculation in Path of Building?

There seems to be an error where the Hit DPS of a Ballista x the number of Ballistas is not quite the same as the value in Full DPS. It looks like it might be related to some rounding in MH More - one number is from the rounded version and one is from the unrounded.

How to reproduce the issue

The PoB is POEGuy's Shrapnel Ballista with Mageblood - all I've done is set to the distance to 35 (to remove one factor) and turn on Frenzy.

For Shrapnel Ballistas, the MH Total More calculation is 1.95 from Ritual of Awakening (5% x19 totems) and 1.12 from Frenzy (4% per charge) - this comes to 2.184, so that's displayed as 118%, rounded to a percent.

The rest of the calculations on the Calcs page seem to be using 118% (x2.18) as the base - the More/Less on the Chaos Hit Damage is 3.052, which is 1.4 (from Awakened Void Manipulation) x 2.18 - 2.184 would produce 3.0576.

All the rest of the calculations seem to proceed as normal from there on (using the slightly smaller figure) up to the Skill DPS of 165,413.4, which matches the Hit DPS in the Main Skill section on the left. When you scale that up to 19 Ballistas, you get 3,142,854.6, not the 3,148,625.2 that the Full DPS reports. But, if you go back and use 2.184 as the MH Total More, you get the Full DPS figure on the nose - I'm guessing there's two paths to those two figures, and one of them is using the rounded version, and one not?

PoB for PoE1 build code
https://pobb.in/Zph_U_7yZPg1
Screenshots
Image Image Image

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Reproduziere den verlinkten PoB auf der Calcs-Seite mit distance auf 35 gesetzt und aktiviertem Frenzy. Vergleiche den für Chaos Hit Damage und Skill DPS verwendeten MH Total More-Wert mit dem für Full DPS verwendeten Wert; das Issue ist abgeschlossen, wenn die gerundeten und nicht gerundeten Berechnungspfade konsistente Gesamtergebnisse für die 19 Ballistas liefern.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
desktop
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.