PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Rounding problem with MH More

Abierto
#9,423 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: calculation
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

N/A

What is the value from the calculation in Path of Building?

There seems to be an error where the Hit DPS of a Ballista x the number of Ballistas is not quite the same as the value in Full DPS. It looks like it might be related to some rounding in MH More - one number is from the rounded version and one is from the unrounded.

How to reproduce the issue

The PoB is POEGuy's Shrapnel Ballista with Mageblood - all I've done is set to the distance to 35 (to remove one factor) and turn on Frenzy.

For Shrapnel Ballistas, the MH Total More calculation is 1.95 from Ritual of Awakening (5% x19 totems) and 1.12 from Frenzy (4% per charge) - this comes to 2.184, so that's displayed as 118%, rounded to a percent.

The rest of the calculations on the Calcs page seem to be using 118% (x2.18) as the base - the More/Less on the Chaos Hit Damage is 3.052, which is 1.4 (from Awakened Void Manipulation) x 2.18 - 2.184 would produce 3.0576.

All the rest of the calculations seem to proceed as normal from there on (using the slightly smaller figure) up to the Skill DPS of 165,413.4, which matches the Hit DPS in the Main Skill section on the left. When you scale that up to 19 Ballistas, you get 3,142,854.6, not the 3,148,625.2 that the Full DPS reports. But, if you go back and use 2.184 as the MH Total More, you get the Full DPS figure on the nose - I'm guessing there's two paths to those two figures, and one of them is using the rounded version, and one not?

PoB for PoE1 build code
https://pobb.in/Zph_U_7yZPg1
Screenshots
Image Image Image

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce el PoB enlazado en la página Calcs con distance establecido en 35 y Frenzy activado. Compara el valor de MH Total More utilizado por Chaos Hit Damage y Skill DPS con el valor utilizado por Full DPS; el issue estará terminado cuando las rutas de cálculo redondeada y sin redondear produzcan totales coherentes para las 19 Ballistas.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
desktop
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.