PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Rounding problem with MH More

Open
#9,423 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug: calculation
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

N/A

What is the value from the calculation in Path of Building?

There seems to be an error where the Hit DPS of a Ballista x the number of Ballistas is not quite the same as the value in Full DPS. It looks like it might be related to some rounding in MH More - one number is from the rounded version and one is from the unrounded.

How to reproduce the issue

The PoB is POEGuy's Shrapnel Ballista with Mageblood - all I've done is set to the distance to 35 (to remove one factor) and turn on Frenzy.

For Shrapnel Ballistas, the MH Total More calculation is 1.95 from Ritual of Awakening (5% x19 totems) and 1.12 from Frenzy (4% per charge) - this comes to 2.184, so that's displayed as 118%, rounded to a percent.

The rest of the calculations on the Calcs page seem to be using 118% (x2.18) as the base - the More/Less on the Chaos Hit Damage is 3.052, which is 1.4 (from Awakened Void Manipulation) x 2.18 - 2.184 would produce 3.0576.

All the rest of the calculations seem to proceed as normal from there on (using the slightly smaller figure) up to the Skill DPS of 165,413.4, which matches the Hit DPS in the Main Skill section on the left. When you scale that up to 19 Ballistas, you get 3,142,854.6, not the 3,148,625.2 that the Full DPS reports. But, if you go back and use 2.184 as the MH Total More, you get the Full DPS figure on the nose - I'm guessing there's two paths to those two figures, and one of them is using the rounded version, and one not?

PoB for PoE1 build code
https://pobb.in/Zph_U_7yZPg1
Screenshots
Image Image Image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the linked PoB on the Calcs page with distance set to 35 and Frenzy enabled. Compare the MH Total More value used by the Chaos Hit Damage and Skill DPS with the value used for Full DPS; the issue is done when the rounded and unrounded calculation paths produce consistent totals for the 19 Ballistas.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.