PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Flesh and Stone's 'Enemies take up to #% more Physical Damage from Hits' should be limited to player/proxy hits

Aperta
#9,386 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

bug: behaviour
Lingua principale
Lua
Stelle
5.4k
Fork
2.4k
Merge medio
1g 12h
PR unite (30g)
26

Descrizione

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

While in Blood Stance, Aura makes Enemies take up to #% more Physical Damage from Hits

Despite the wording, this effect doesn't debuff enemies generally. It's an offensive property that applies to hits by the buffed player (or their skills via proxies). Bug report here, which includes an ingame demonstration with minions.

The stat also does not scale reflected physical damage (like Reflects 100 Physical Damage to Melee Attackers mods). It does work for impale hits, though again only if caused by player(/proxy) hits.

What is the behaviour in Path of Building?

The effect applies to any physical damage taken from hits.

How to reproduce the issue
  1. Add Raise Zombie
  2. Add Flesh and Stone
  3. Observe damage goes up
PoB for PoE1 build code
eNqtXFt32roSfm5_hRfvDbG5pot0LwK5rZU0HEjbc85Ll7AFaEdY1JZJ2L9-jyTfwSBj9yEFaebTaCTNjEaTDP76WFNjiz2fMPe6YV5cNgzs2swh7vK68eP17ku_8de3z4MJ4quXxU1AqOj59vnTQH42tgS_PzMHXzcenycv09eGgXwbu86IIt__jtbQ8Z25uGFskMtXmLnP6G_m3TNnr524mXY7AZjZIFvDmCPXITzuXyEP2Rx7T3iL6TDgTInBvQB614i4M2a_YX7vsWADE2sYHHlLzH9GU239hqlSwSx6YUafBhOKdtibccQNH35cN4Y2J1sMogHHE1kT3jC2iAYwTLfRLGABXaIlfkjRXp6gvQk8n4_RGj6e5pltMHZiMvPC7HXbvctOv2-1Oq0ippFH-HNAOdlQgr0Ud6eIA-QfrZBrJxKZl4UyvTKO6HgyOy29omQauvlF-OqGwly1cAX149IlHGuTTxjxmVtKai3iUUApHBEt2in2sbdFnGgKMmLrOXE1dfKMXDRifqJrq3-MdII9OLg8w3F5gmGGbQZnPc3Ssi6u2ma8KzVGPIxTOPQTWWB9ylKzChnKSnPePG5nunSlgc8TaAr2R49yxgKqSckTa2MdOQZ_0oRXhbtmjD_04NKE3UK4R5frwaUJzU6nWLwt49JXaVmU24dJcmz6F5Z1ZVq9y17PKhxgstr5xEb0GX2QdbAGI_2K3nAyXvfIPl2uuAt2qYi11StivSMeLs81YtQ5g2uFmF_I1j92CjWUAL7T_ipoH11b72j_cD1polMut3uUYQoHTnj1OcWaHMkQ4bHV8bhqqCV2w_F2etN5wthe3UNsNEUc61n5mKpzXK2CVkutgvCAWov3RJYhr6Re-xhfgY4uro4xldTSrYu95W62Ipg65agjwUZooxX42V_T3Frazg5XasOkWUuq5BfyHD2HU1amLfLTBtbsHleXItfblxiiTWBwcC7wLeSYeOxvDDcEWo5t6K1Z4GkuuCLWmkDkHNRNYoqdwNZzRreLBZYXnRsKVybdacRcICelpViHnCP7bcycpbbS5CClOLLyzYLNBkyI2A26AMLvQYBOUnHOl64G9QtsZa0TLVyk_gAJtfYAsdPXHyXHoj8X4bhLTCYh1x4iXtBnMBZr8AHyKgy3_sQaFC4O3Mm07kySUPOiN2HvIPlKZBX8ctQQ4CR-r1AUD7v_7LTxM-RaA9y6TuCJo6A9Rp5Da5jTORTVt58XyaVEzKvOhdlvd4q4spmRy4t-B66gl9HPern2Mh5mt3vRt9qtTv-q1251j_MdyH_sUR7Mf2iOcjgbUoJ5PzdScn6HDtAe8ZFMyR7tiUzJPvaBTInmHDKXiV633T9GeDx-OchyPJbaYzkaXh6lLimbfrz3StYQLPn-GHFk-Bh59uoJLPkdonQOjv260TCc8Cr8E3kEudySGdhcoykbE37gE_iDpkwti08j5i7I0kDShKgvM8zjfG3cYhAnapQWyMYr8JbYM1yZQMYuXu9knrhhuMF6jr3rRj-8Nxyin9kMRJqJIMVPOMxiBjlAaEki8l50eytkEFnZKBiJuDoaPJFdjHhapwZKRzLxQKeY4kggP5xltU-pIh3Z6AzokyWhLwvpI0Ht0hlpqF3sQjyGUbI6NDu6U5uI7EKsxlOTSoc4OrrfxPeDfRnblxoqLCWeWORSDNE9JKLvmlf9qxM88f0r1vWl2T4y0GwF14KyB0kqOr_r-lddDQWcuVfPYNuLrXX2ua0MFlzsuIfoK1lCSMgCl-uf_-wlr5TE4b2QUTpFbpq3d0TidfxqJOIC7GFHrqaUeobpYv_UDZqxWZbGXH0TH2dvhFLf8JnH7_Hav9mBc44e7DKNd8IF5Xy4v2Lv4hKn6F53G-xDoPj0JLzKAoGU0PqfAFHCd8JRpVqf1Bufy7x1nDlVeEPKQxYx9HVjgagPsih3I6VNe5uoIeNsZKOBXZHwc9Kvj8MERLo54to0cPCjG95FQCBC90hHiNq-pKdoLqRWw3wagIDRY6UFs1vi9aMjchYcOeCEm48cJtAUs2hKHPg0RcTH_xcqFEsNiym2nUi6QLMRtfuCWEUC4dCy3znQn5Mv3yMb_yhtCtHGSv-NvG7U13vK5oha8eonYHkJtipWEJCZGf1JrXUa04wwbbFFE1HzAOGOV-oqs5Zy2UqtpuyqvJ53EHGthi6cP_n-nayo7DCQ6xhh17mrkFJ1brBzlJ2F2FN3-DGyEso2iI-Pa3HGDfwh_psgTwyrDqYMDqVmlDWAqHVMFgswSuBa_UgUdXoFWXh4jcDH6h3sF0Yb2K6iWayJFCMkLCTKnnbK4PgDx2T-Y_ok4lzxRcz2shEazBsM6m5qk6vRDLMEyxBsMi4zxgOma3yGUFYJlhvm7IwwotDngl20hVivzDCMl6GfgoMupVzJYJVlaJVguKPIfyslk-KwSnOUl6pdmqNzxrYyZu9oYwznO99H1FBlOqWEjYFyGFYNGO0aMLqlD2cNMzEPqrVTF1D3HKAchlkDhlUDRqsGjDL7RPiEKvNIGdcqyyKNZxUAZa6rrOphBKsyQqsyQrsyQrcuU9iuC6g249ytwSiadVkiswZhWnUJU4fLqc1Gtyr7ndoWqV1ZlOqTqS5DpzJCtx4zb9YDU5PTadUD064HplODN68Dozb7b9YFdHYUWdkXnu15qoYzZlUAqypAqypAuypAGeXfe2hRUmsHglmz9IhWxRFbFfmrhu-divzR63MzzD_JJJjMbcl3T5E4VOkpdxPw6JVM5Mh-q3z73mtKhnJNfPv3PFgsxO_ENAyfe_LXeW7v7m5Hr48_b0OWGZYVYobNKEUbX6QHwxS4SHqF-TkKRAARzH1Ffd34SfC77Bxjjgj1tdAeknfLNJbESfp0kH4hz_aIeCJMA91-YI_DLONeHShZibEnjpJFvJqLh249Xam33zSUKnIbIZ_LN3QdFPG4mwURLXpTeVxvEM0pN2zTXmzxqiKyqv4BpXDx4rLBNlkQW9Fornr0wp3RjW0HHrJ3WhiyCibLr5p0mFUlS5Y7bNPSqqyiyWlVtWntL2yjXZZbNekwxzUYWYC4mbnil8x0kG4pHhIqSuZyK_uduXKzw7mJCXQAn8G-qHK8HOCLeCOMenSQ4JR4ZB7w_HFOtWvpStbsZNQkWrTmIovc06yyRUuvmdKcjDVK92gatRyEbNFhjR6g08yqTXMJwjqAjPpTmfxTSohKAjLzDxu1Dok0t8MtI86-pch3VgaUhco1yCVKkavD5GuTtRBl5j13XsK2Qnb1NlbE_YMT8b5XDUScuGoI4uBVQ3glrs0DD2sBTPeikenRGCThjCtmM746bDyXP66uPRtB1QCfzS7Lr7Tt_xgv5LvrAQcQd1XDumMQ0UG4Ias-K2LNeOCOQb3HoRIFnZihhkHSx1Ket5TSlFEJfz1u316qjupAEBc86AaghUhx3f4DRlTUFjNaDTD_-4EaS1CIJcpjgw1ynQjtpUzYX6w9uJYDqCxkHYsyXL-SlLeyfivBGTSjG-LgO4MYSUCL1ujL4NXDWFzTwuraGffEzfQfxqJqqJb69l95TRWf_ic_FddVyGFlOYYxE6VTzlZs_1dYzKRwysE-XMFQGEJQ2jDQZoNdJ1PAIUSLSqxk_UpUXgVfDBfuq4DX6fdbLVFO43Ps7cJ4UsxA_lWI8HLNxRyTv-Zg9TJ_eyIk8mVNB_J2w2xXVP_xaQC3dlWTs-J8439tNt_f3y82iK_YAn8Qii9stm5ugA0E_iKv4F_EyM0h_LtZDuU_VdsSIQ3UHd8PMwRiR3kE5hXe-MVE5RoKTXz7PGjm_7bGv8Uzmrg=
Screenshots

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Non è indicato alcun file sorgente o test. Inizia riproducendo il problema con la configurazione Raise Zombie, Flesh and Stone elencata e il codice della build PoE1 fornito, quindi traccia il calcolo dei danni fisici per colpo di Flesh and Stone. Il lavoro è completato quando il modifier viene applicato ai colpi del giocatore o del proxy, inclusi i colpi di impale, ma non ai colpi dei minion né ai danni fisici riflessi.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
lua
Ambito
game-dev
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.