PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
The Dancing Dervish's implicit of 60% increased global accuracy is being calculated in unarmed/unencumbered builds
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
The global accuracy of the weapon is not added, correctly, once I get Rampage and the sword leaves my hands. Goes down from ~4800 to ~3500.
What is the behaviour in Path of Building?
The Dancing Dervish's implicit of 60% increased global accuracy is being calculated in my unencumbered build even while having the "Disable Weapons" buff from Manifest Dancing Dervishes.
How to reproduce the issue
- Add The Dancing Dervish to build.
- Switch to Calcs tab, verify in buffs section that "Weapon Disabled" is true and that the active skill is a melee skill that the player can use without a weapon (I use Cyclone).
- Click on the "MH Accuracy" number to see the breakdown of mods, you will see "60% increased | Global | Item | The Dancing Dervish, Reaver Sword"
PoB for PoE1 build code
https://poe.ninja/pob/75b38
Screenshots
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Load the supplied PoE1 build code and reproduce the issue in the Calcs tab with Weapon Disabled true and a weaponless melee skill such as Cyclone. Inspect the MH Accuracy breakdown and verify that The Dancing Dervish's 60% global accuracy modifier is excluded while the weapon is disabled; done means the displayed accuracy matches the in-game unarmed state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100