PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Skill-part DPS multiplier overrides multiplier from General's Cry
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Lua
- Sterne
- 5.4k
- Forks
- 2.4k
- Ø Merge
- 1 T. 12 Std.
- Gemergte PRs (30 T.)
- 26
Beschreibung
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What platform are you running Path of Building on?
Windows
What is the behaviour in-game?
General's Cry dps scales multiplicatively with both warcry CDR and shotgunning.
What is the behaviour in Path of Building?
The effect of General's Cry cooldown on dps is added as a skill dps multiplier. This works as expected when choosing '1 Wave' for Shield Crush, but choosing '2 Overlapping Waves' sets the dps multiplier to 2, ignoring the effect of warcry cooldown.
How to reproduce the issue
Observe the dps change in the sidebar or the calcs tab when changing skill options for General's Cry-Shield Crush. Choosing '2 waves' should double damage but instead changes it by a different amount.
Character build code
eNqtW-tz2zYS_xz9FRjN5OZuWlsS9bDjs9uR5eecHauSnd596sAkJKEBCZUE7aid_u-3eJCiFIEiRSYzCUns_vYB7GKxpM5__uYz9EbCiPLgotk5bjcRCVzu0WB-0Xx5vjk6bf78U-N8jMXiaXYZUyZHfmp8OFfXiJE3woCviQQO50R8SZC6vwHSEgdiQXjwiH_n4S33LpqfeUCa6BUHHhXJnctwFH3GPrloTl1gbiIcuSTwRuvnhnCBQ-wKEj5IqcNY8EfuwagIYxj1MQ2m3P1KxG3I46VS6o2Sd01z_zh-mjxnVKJBViWw6MP5mOEVCacCCxTBPxfNITgGz8kV9uFfQMMsBqhBb3Dca5-0TwedgXPSabZymS_jMBKHIUyXhHgpk5VsHJLr2Yy4gr6RUUjFaIEDdy2sb-PbQds7_pRL_hgzQZeMknCt1rGV4-47_E-fbLTPXGB2NZ6ucdsng2NncHp60jtxPp3m83GR8rVtlL9Ssbhk4NEDpEje-3lABTmQecxpxIMK9mVZrSaOYsYgPAvRTkhEwjcs6KZadmzuv9LgIO8NQ4KfZnqNTrBH4-iRiJBEKU7XvoamYr3UnBxj_sgSdvpWvCvyrQDefSCKSc0SnuYIfeNCZbZ9XlbTfX03TilpMLPG_WIVURezR_yN-rEP0faMv5K1kH5nYGN9oPOFCGCp2Hgd58TGe0NDcgDbiDPvELYF5pGNr2tdck-z2R1sMkPXjWHLWK0TXNvuklkmQbdzcrJ7JmnvA3f_dErClyBUoZZJ5YNchglxudw7XhkpyLEWMSYhbJ0iE6F7RM1JYOStipnzQIi7uIW9doIF2c_yiAO8XpH5bpW0hdwqCXe4tV-QoYSTJKPFScef8phKuuk6IOF8NV1Qwtb2OKedIvSJaiO8LMKqXJ3lL-TyTYGlVk2WtaRbfsWhV2Arg9qqrE5vOMomZHuq1O7S5MUWJ4EiAxg8slX8tO0FHP9dlm-sHNsw9Hmc2fS63V6uEZq-kA3J1qLr1gnxYndj__pkd2xSiV4yqMW3TOk6e9lAU8Z28drdIAR2v15xb17Yc0pIKY5N_abxcgnJRC6JogBy14SSi0brtHPUL0D9BOs5G9jtvP21uIA1dWEBac1QXMoWS3Fb5Ka_LWZQhLywiHRCHyFj-LAbqMMWnBWzCd5eA0GhXahqVoQFq_cxfwflF_IcHZWjhvpoHWNWVUIS_LkqjL9BXkjAdeBBsQXRUFjGNscuMc_Uh4QaRVdYYOSZQvoLDikc5B11yI8IDt3FA8z-DWbsFZLBRTP7VN5tMXaS4_R5S_Ux5NW9v-ShQOSb_G-MQ7G6aM4wi4gmVE8AJxI0UKcmyDyMNdF0wd-H3pu04plzFiVMCC-XJPA2MJ5DQhBO8ogrlVA2yhvk40jA3qUXZiSVzrRB7j3pRhRwUAAKndPTblea6PLAw-FquEkYUNALDlgk041x-qbRopGk2A_nL5MHdfFhIcQyOmu13t_fj5dYLPiMfIPt6NjlfmsJTKDwUfSVMnYkYVtD-HM5H6o_CqiVIJ3rDkzU0ncyHEMKOuu5bElDldelJ-TFZy5IJMfkw-TmfCpFRSiCibglfnS5gvi5keXD1jHUuFJST4nQiyHLk7SGPDLDMZPPf4kxo3Jm29mnD7qLFfDQT49TAAUzKzO9RnxeLaXrhw8PemTIhAGT4pJp1tNpFELUS6bYPFRNquFa6xFmLvA6TUQDl8UenCpMajGzyPCr1Ew25eR5wMs2uzI4EkLP5DloY4hvGX_FzElYTKsOjrNoTny5DOAUjj0Iq9a9ABNa0o6WgoOrWwJVG5g00tWUihrJs_FcLYnvnv6R8bG5ljRX2t3NDe06iXZb9rk8DvSEBtg3wWKE_AMvefTvCElZrX1GKw1l6K49Xc4PumwdhXG02PDDxvPUDxtPs35I9VA21ekVLRJpmSbstPYm5MxiVGGnA0teKn8oivtgGQsFeNH0aeT-9hrPZrJpClqLUPWBr29urkfP91-uTU7OsijLfgti_1U2BfX_62bllKjCEUXxa6QvL5pfKHlXilyB3ymLpF2M4WVE0mypIsdozoAvB01R3dG0xboba01gR7r-RkJI7nM4dLghJVa90vE9SmmB8kAi9zAbmuxd2oF0cTuCrUEfmCyeUo1iO4ps3VrNkYM5vLAtYmaVbEb3eELI3Amrlc6oK7f__CmXmVZT5fglbexY59tU5nYM1Qy2AehBO7Nu6Nq4zWiOV1Uz2epVPWpnvyIuttquB-3M6RmcB-AmG0pKlYP0mQdqkUPQDCmTVbR1Zq8ZSUnsgE9iQUJTAdmQHiFHJSS5gRPS11jYwzhDkeMr1RW0eEiO2Vl158tigxzLyUQb3SCLQ7M0dijdQbEmsjxWfaKy-s-cz3KmwPQnLO7XozlOSFo0FvvNcE6QqPw7fOPU02d0S7hskeUlDChuq8OoxkN1mO1ORHXEGzgffLXOtxm1s78IKquaHSi6eikEIoOqGoKMrWoIz1CMizgkBwNMtiuRNe8kvwZJj847mZPRvMxhTtQHI-hz_8Hsqi1xMLfK_1ASE7AgdwNIaXLiQ8TBFThD5MRGQSil1u5EsrauFJbeCndaWhpRB7h5M5aXAzTJHiDYy-9yqsViSGl37Y5gJt9-c1YN8Ls3gFXA5GuCeIkDL4F72lWjr-ehoPe4iABT9ZOu5NuIqj4MiL_aAWTX67yVnOpUp0mes0wbbCpC2UT4k3P_f-o8Kq9M16NrOh1QcV9RmLdQrbdEjiT8b9LCO1cHZNN2kddp18UOEEdkqvpUvxI4uAeKQ7Y29EESMJJTtdIk0zGZwGOxOkMvn-9_ebluDMmcRmgYhzzEDcgk_lI67D9QJyNdBDV0RXGG5IsQc3OJI2Le9lFGYKihyybDcoack3YjW0l9z2A6hmdoHBLUOe4ctzcfdY_72UejOAT7RUOfW4mH0pFuw_SLQGq7YfpkZ-jyCP421FxMyB9naOA04FDFqEvlaLvxl3HPWedH5--_ILfPyVn7uP_3P0_bR512-18fZesoJKC3h7TRCFYh2rBzDdLdgOi220e9ohg_dNofkeAIM4agmpf5CzOkq0CZFqPGD31F4OtYRfIdQ2a88cPgI9KHMkmliqmMdX-bl3ebUhGRvRJJ3_uI-CzR7n1BArTi8TaK82N3H46Th5PxTad95Gx6Zm20Djz0TsUC6RM60p0V1X155N5E4iCFJl8k9JOFbfozVgpnL0V3L0VvL0V_L8VgL8XJXork2wzVVUujXbZFbSlhs1_KuEAQ3f749WXyILOX7jfdMphdyIhySPeyW_kMWgjqlGC55JDL0fB1FUUw2zpUUb8MAGFim98pwa8qTNQ9wEo0fcfLbdG9Q4AqmG8wnBowdhs0qMGgQQ0GHYSxy6DKq7Nbg0ecuqwps97uCJTCopI_dgTboLIGTmmEyiK7dfm_X8Ni6NQQHp0a9OiVXAl1pRinakT2anBg-T2jthTbrWq_UzGEyyngrZKarsIa1LVFFYTdgd2vjDCoa1o7deWY8kuzuh97leeyX8-iKmP80I8ZETVkwm4NCaVbMSh7Ffk79fj_4J2y9KLtleY4pIpas3QO8Wq_aq6uaVp6dSWX2urqg49QJfgmNJiXmvXdqcmpZw5q2ynqOPD1DrOprPOr7_E1FRv9yopU3-IGZZNB1eTxvUDd80k-OlJNY_XNEQ9mdG7ax_rGNJAVU_pkow80ZtglC848EholiGyMm99GJt8bnbRT3S0M2V87Jlx9O890AcZNZWsv-u6rJquMZPWm9E6OAJerxnw5CdKK5EunhKebY7qf_mBT_gqRhMRTEkfyQ7IpYbOM5P4e0Zu_Cci4fg-f-Q0BZ0z1CbNztocz_QIg4RjkyIronLKnmXr_CDaql6jbX6O10iWm35aou58a563tnzf_H0B0fN0=
Screenshots
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den Fall General's Cry-Shield Crush zu reproduzieren, und vergleiche die Seitenleiste oder den Tab „calcs“, während du zwischen '1 Wave' und '2 Overlapping Waves' wechselst. Verfolge die Skill-Optionsberechnung, die Warcry-Cooldown und Wellenanzahl kombiniert. Erledigt ist die Aufgabe, wenn das Ergebnis für zwei Wellen den Schaden verdoppelt und weiterhin den Cooldown-Multiplikator anwendet.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- lua
- Bereich
- game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100