PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Add trigger functionality to Focused Ballista Support
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 5.4k
- Forks
- 2.4k
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 26
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Is your feature request related to a problem?
It would be nice if Focused Ballista Support could "trigger" supported ballista totem skills, limiting their attack rate the same way that Asenath's Chant or similar effects limit the trigger rate of spells based on the attack speed of the triggering skill.
Describe the solution you'd like
Adding Focused Ballista Support to a skill group should cause ballista totem skills in that group to have their attack rate limited to the attack rate of a "triggering skill" that is used by the player, subject to the same effects as all other triggers in PoB (missed trigger intervals reducing the trigger rate, warning when no trigger is found, etc.). This would of course use the totem's attack speed as the limit to the trigger rate, as opposed to other triggers that use an internal cooldown.
Describe alternatives you've considered
Currently, to calculate true DPS from ballista skills supported by Focused Ballista, you have to do all of the trigger rate calculations and comparisons by hand.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Focused Ballista Support handling and the existing trigger calculations in the Lua codebase. Compare how current triggers handle attack rate limits, missed intervals, and missing triggering skills. Done means supported ballista totems use the triggering skill's rate and expose the same warnings and rate calculations without manual comparison.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- backend, game-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100