PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Damage over time calculations not being affected by Damage Taken As Other conversion
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 5.4k
- Forks
- 2.4k
- Merge moyen
- 1 j 12 h
- PR mergées (30 j)
- 26
Description
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
- I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?
When using items that change damage taken to another damage type, (E.g. 40% of Physical Damage taken as Fire Damage), 40% of all physical damage, including damage over time, is taken as another type of damage.
This other type of damage is mitigated accordingly by resistances and other sources of damage reduction against damage over time.
What is the behaviour in Path of Building?
The Effective Phys DoT pool is not updated appropriately when equipping Cloak of Flame.
In the example I'm using, under Dots and Degens it shows the calculation of Physical DoT Taken, as follows:
DoT taken: x 0.9 (accounting for soul of arakaali pantheon)
Total Pool, 2,737 (Life: 1 - Non-bypassed energy shield: 2,736, TotalPool: 2,737)
Effective DoT Pool: 3,041 (Dot Damage Taken Modifier: 0.90, Total Effective Dot Pool: 3,041)
However, when adding cloak of flame, or even taking off any chest armour and just adding 40% of Physical Damage taken as Fire Damage to the Custom Modifiers, the Effective DoT Pool remains unchanged.
How to reproduce the issue
Use a build where fire resistance is higher than flat physical damage reduction
Either equip an item that modifies physical damage taken into another damage type, or add "40% of Physical Damage taken as Fire Damage" to the Custom Modifiers.
See Dots and Degens section within Calcs.
Character build code
https://pobb.in/Y28YlO5grrIB
Screenshots
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Reproduisez le problème avec le build de personnage lié ou avec un Custom Modifier pour 40% de Physical Damage taken as Fire Damage, puis suivez les calculs de Dots and Degens. Comparez le pool de Effective Phys DoT avant et après la conversion ; c’est terminé lorsque la portion convertie est mitigée par la résistance au feu et que le pool effectif est mis à jour en conséquence.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- game-dev
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100