PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Damage over time calculations not being affected by Damage Taken As Other conversion

Offen
#7,319 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: behaviour
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

When using items that change damage taken to another damage type, (E.g. 40% of Physical Damage taken as Fire Damage), 40% of all physical damage, including damage over time, is taken as another type of damage.
This other type of damage is mitigated accordingly by resistances and other sources of damage reduction against damage over time.

What is the behaviour in Path of Building?

The Effective Phys DoT pool is not updated appropriately when equipping Cloak of Flame.

In the example I'm using, under Dots and Degens it shows the calculation of Physical DoT Taken, as follows:
DoT taken: x 0.9 (accounting for soul of arakaali pantheon)
Total Pool, 2,737 (Life: 1 - Non-bypassed energy shield: 2,736, TotalPool: 2,737)
Effective DoT Pool: 3,041 (Dot Damage Taken Modifier: 0.90, Total Effective Dot Pool: 3,041)

However, when adding cloak of flame, or even taking off any chest armour and just adding 40% of Physical Damage taken as Fire Damage to the Custom Modifiers, the Effective DoT Pool remains unchanged.

How to reproduce the issue

Use a build where fire resistance is higher than flat physical damage reduction
Either equip an item that modifies physical damage taken into another damage type, or add "40% of Physical Damage taken as Fire Damage" to the Custom Modifiers.
See Dots and Degens section within Calcs.

Character build code
https://pobb.in/Y28YlO5grrIB
Screenshots

image

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Reproduziere das Problem mit dem verknüpften Charakter-Build oder einem Custom Modifier für 40% Physical Damage taken as Fire Damage und verfolge anschließend die Dots and Degens-Berechnungen. Vergleiche den Effective Phys DoT-Pool vor und nach der Umwandlung; als erledigt gilt, wenn der umgewandelte Anteil durch Feuerwiderstand mitigiert wird und der effektive Pool entsprechend aktualisiert wird.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
game-dev
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.