PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Damage over time calculations not being affected by Damage Taken As Other conversion

Abierto
#7,319 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

bug: behaviour
Lenguaje dominante
Lua
Estrellas
5.4k
Forks
2.4k
Merge medio
1 d 12 h
PR fusionados (30 d)
26

Descripción

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate open and closed issues by using the search function of the issue tracker
Check for support
  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the behaviour in-game?

When using items that change damage taken to another damage type, (E.g. 40% of Physical Damage taken as Fire Damage), 40% of all physical damage, including damage over time, is taken as another type of damage.
This other type of damage is mitigated accordingly by resistances and other sources of damage reduction against damage over time.

What is the behaviour in Path of Building?

The Effective Phys DoT pool is not updated appropriately when equipping Cloak of Flame.

In the example I'm using, under Dots and Degens it shows the calculation of Physical DoT Taken, as follows:
DoT taken: x 0.9 (accounting for soul of arakaali pantheon)
Total Pool, 2,737 (Life: 1 - Non-bypassed energy shield: 2,736, TotalPool: 2,737)
Effective DoT Pool: 3,041 (Dot Damage Taken Modifier: 0.90, Total Effective Dot Pool: 3,041)

However, when adding cloak of flame, or even taking off any chest armour and just adding 40% of Physical Damage taken as Fire Damage to the Custom Modifiers, the Effective DoT Pool remains unchanged.

How to reproduce the issue

Use a build where fire resistance is higher than flat physical damage reduction
Either equip an item that modifies physical damage taken into another damage type, or add "40% of Physical Damage taken as Fire Damage" to the Custom Modifiers.
See Dots and Degens section within Calcs.

Character build code
https://pobb.in/Y28YlO5grrIB
Screenshots

image

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce el problema con la build de personaje enlazada o con un Custom Modifier para 40% de Physical Damage taken as Fire Damage, y luego rastrea los cálculos de Dots and Degens. Compara el pool de Effective Phys DoT antes y después de la conversión; se considera hecho cuando la parte convertida queda mitigada por la resistencia al fuego y el pool efectivo se actualiza en consecuencia.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
lua
Área
game-dev
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.