PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Incorrect non-damaging ailment calculation with minimum shock
まだ誰も着手していません。
- 主要言語
- Lua
- スター
- 5.4k
- フォーク
- 2.4k
- 平均マージ
- 1日 12時間
- マージ済み PR(30日)
- 26
説明
Check version
- I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Check for support
- I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?
With "Shocks from your Hits always increase Damage taken by at least 10%" mod, Level 5 Awakened Unbound Ailments and 7 Affliction Charges, I should get at least 26% shock on everything as long as I'm dealing crits with at least 1 lightning damage.
I haven't tested this in game, but this is the general consensus as to how Shaper of Storms and Shaper of Winter work, as per Mark's response on https://www.reddit.com/r/pathofexile/comments/81b41p/comment/dv3emop/?utm_source=share&utm_medium=web2x&context=3 regarding now removed Beacon of Ruin ascendancy, which was a combination of Shaper of Storms and Shaper of Winter.
What is the value from the calculation in Path of Building?
In Path of Building, the current shock modifier reads 15% with the setup above, even though the shock effect mod reads x2.64, which is correct. I have no clue how Path of Building obtains the 15% value.
The issue is not related to Affliction Charges, because the calculation is still incorrect without Affliction Charges. With Shocks from your Hits always increase Damage taken by at least 10% and Level 5 Awakened Unbound Ailments, the shock seems to be 10% although the shock effect mod reads x1.69.
How to reproduce the issue
Select any skill and support it with normal or awakened Unbound Ailments
Add custom config for "Shocks from your Hits always increase Damage taken by at least 10%" (this mod is supported and works, because changing the number changes dps) or allocate something like Shaper of Storms/Scion Elementalist
Check Non-Damaging Ailments in the calcs tab
Character build code
https://pobb.in/KEHutQQ6uQev
Screenshots
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
まずリンクされたビルドを読み込み、Unbound Ailments と最小ショックのカスタム設定または Shaper of Storms を使って calcs タブで結果を再現します。ダメージを与えない ailment の計算を追跡し、shock の値を shock effect multiplier と比較して、表示される shock が期待される最小値に達していることを確認します。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- lua
- 領域
- game-dev
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 42/100