PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Incorrect non-damaging ailment calculation with minimum shock

Offen
#7,219 8 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen

Dieses Issue hat noch niemand übernommen.

bug: calculation
Vorherrschende Sprache
Lua
Sterne
5.4k
Forks
2.4k
Ø Merge
1 T. 12 Std.
Gemergte PRs (30 T.)
26

Beschreibung

Check version
  • I'm running the latest version of Path of Building and I've verified this by checking the changelog
Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Check for support
  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).
What is the value from the calculation in-game?

With "Shocks from your Hits always increase Damage taken by at least 10%" mod, Level 5 Awakened Unbound Ailments and 7 Affliction Charges, I should get at least 26% shock on everything as long as I'm dealing crits with at least 1 lightning damage.

I haven't tested this in game, but this is the general consensus as to how Shaper of Storms and Shaper of Winter work, as per Mark's response on https://www.reddit.com/r/pathofexile/comments/81b41p/comment/dv3emop/?utm_source=share&utm_medium=web2x&context=3 regarding now removed Beacon of Ruin ascendancy, which was a combination of Shaper of Storms and Shaper of Winter.

What is the value from the calculation in Path of Building?

In Path of Building, the current shock modifier reads 15% with the setup above, even though the shock effect mod reads x2.64, which is correct. I have no clue how Path of Building obtains the 15% value.

The issue is not related to Affliction Charges, because the calculation is still incorrect without Affliction Charges. With Shocks from your Hits always increase Damage taken by at least 10% and Level 5 Awakened Unbound Ailments, the shock seems to be 10% although the shock effect mod reads x1.69.

How to reproduce the issue

Select any skill and support it with normal or awakened Unbound Ailments

Add custom config for "Shocks from your Hits always increase Damage taken by at least 10%" (this mod is supported and works, because changing the number changes dps) or allocate something like Shaper of Storms/Scion Elementalist

Check Non-Damaging Ailments in the calcs tab

Character build code
https://pobb.in/KEHutQQ6uQev
Screenshots

image

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Rechercherichtung

Beginne damit, den verlinkten Build zu laden und das Ergebnis im Tab „calcs“ mit Unbound Ailments und der benutzerdefinierten Konfiguration für den minimalen Schock oder Shaper of Storms zu reproduzieren. Verfolge die Berechnung des nicht schädigenden Ailments, vergleiche den Schockwert mit dem Multiplikator für den Schockeffekt und bestätige, dass der angezeigte Schock das erwartete Minimum erreicht.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
lua
Bereich
game-dev
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
42/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.