PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Make Damage over Time cap optional by adding the checkbox

Open
#6,904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
5.4k
Forks
2.4k
Avg merge
1d 12h
Merged PRs (30d)
26

Description

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

At this moment Damage over Time cap is applied automatically from
\Modules\Data.lua
DotDpsCap = 35791394, -- (2 ^ 31 - 1) / 60 (int max / 60 seconds)

and available as
data.misc.DotDpsCap

If you want to see raw DPS without cap for comparison purposes, you have to switch to Uber Boss, but it also capped at the same value. Or you have to add some modifiers manually like
90% less Damage

Describe the solution you'd like

Solution is to add dedicated checkbox which allows to ignore the DoT cap optionally.
[ ] Ignore DoT DPS cap
Default value is OFF.

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how data.misc.DotDpsCap from Modules/Data.lua is consumed in DoT DPS calculations and where calculation options are rendered. Add an opt-in checkbox that is off by default, and verify that enabling it exposes uncapped DoT DPS while the default preserves the current cap.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
game-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.