PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding

Militant Faith search: more than 2 devotion modifiers

オープン
#6,719 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

enhancement
主要言語
Lua
スター
5.4k
フォーク
2.4k
平均マージ
1日 12時間
マージ済み PR(30日)
26

説明

Check for duplicates
  • I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?

I would like to find jewels with any two of Totem Damage, Area Damage, Elemental Damage, and Increased Effect of Non-Curse Auras per 10 Devotion.

Describe the solution you'd like

Allow the user to specify a "starter trade settings" link. Use this as the basis for all other trade links. e.g. the user might choose to search for Timeless Jewels with two of the their chosen devotion mods. An example link would be https://www.pathofexile.com/trade/search/Ancestor/7pkrXv2S5.

One challenge with this will be filter complexity. I don't know how hard it is to know when approaching the max filter complexity when PoB is generating a link. This may reduce the number of jewels in each search, and this reduction may not be obvious to the user.

Describe alternatives you've considered

There are several other options for how to implement this.

The least flexible but simplest to use and perhaps also simplest to implement would be to have a multi-select box and let users pick how many of those they want (1 or 2). This has the advantage of requiring less work from the user and making discovery of what can be done simpler. It also limits the complexity of the trade link since it's at worst a count box containing all available devotion mods, though more likely it's just a few.

Another more powerful option would be to let the user specify a weight for each of the modifiers, then search with a specified required total weight. e.g. it might be that one modifier is great on its own, while the others are only good in combination with another one. This is almost as powerful as providing for a starter trade settings link for looking at these modifiers specifically, though obviously it wouldn't allow for doing things like looking for particular corruptions. There's likely to be zero of any given seed with a particular corruption on it, though.

Additional context

No response

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

issue ではファイルもテストも指定されていません。まず、既存の Timeless Jewel trade-link 生成と devotion-modifier フィルターの処理を特定してください。現在の制限を、要求されている two-of-four の検索動作と比較してください。完了の条件は、使用可能な trade link を生成し、フィルターの複雑性に関する制限をユーザーに明確に示すことです。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
lua
領域
tooling
issue の種類
機能追加
難易度
5/5
見積もり時間
1週間以上
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
25/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。