PathOfBuildingCommunity / PathOfBuildingCommunity/PathOfBuilding
Militant Faith search: more than 2 devotion modifiers
Personne n'a encore pris cette issue.
- Langage dominant
- Lua
- Étoiles
- 5.4k
- Forks
- 2.4k
- Merge moyen
- 1 j 12 h
- PR mergées (30 j)
- 26
Description
Check for duplicates
- I've checked for duplicate issues by using the search function of the issue tracker
Is your feature request related to a problem?
I would like to find jewels with any two of Totem Damage, Area Damage, Elemental Damage, and Increased Effect of Non-Curse Auras per 10 Devotion.
Describe the solution you'd like
Allow the user to specify a "starter trade settings" link. Use this as the basis for all other trade links. e.g. the user might choose to search for Timeless Jewels with two of the their chosen devotion mods. An example link would be https://www.pathofexile.com/trade/search/Ancestor/7pkrXv2S5.
One challenge with this will be filter complexity. I don't know how hard it is to know when approaching the max filter complexity when PoB is generating a link. This may reduce the number of jewels in each search, and this reduction may not be obvious to the user.
Describe alternatives you've considered
There are several other options for how to implement this.
The least flexible but simplest to use and perhaps also simplest to implement would be to have a multi-select box and let users pick how many of those they want (1 or 2). This has the advantage of requiring less work from the user and making discovery of what can be done simpler. It also limits the complexity of the trade link since it's at worst a count box containing all available devotion mods, though more likely it's just a few.
Another more powerful option would be to let the user specify a weight for each of the modifiers, then search with a specified required total weight. e.g. it might be that one modifier is great on its own, while the others are only good in combination with another one. This is almost as powerful as providing for a starter trade settings link for looking at these modifiers specifically, though obviously it wouldn't allow for doing things like looking for particular corruptions. There's likely to be zero of any given seed with a particular corruption on it, though.
Additional context
No response
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
L’issue ne nomme aucun fichier ni test ; commencez par localiser la génération existante de trade-link de Timeless Jewel et la gestion du filtre devotion-modifier. Comparez la limite actuelle au comportement de recherche two-of-four demandé ; c’est terminé lorsqu’un trade link utilisable est généré tout en indiquant clairement à l’utilisateur toute limitation liée à la complexité des filtres.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- lua
- Domaine
- tooling
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100